diff options
| author | Sam Ravnborg <sam@ravnborg.org> | 2020-07-19 10:07:37 +0200 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2020-07-20 11:27:03 +0200 |
| commit | 5a09765ddedd34f176275c72ffbe567e428e2dfc (patch) | |
| tree | 068e056f32ef45103974c23ebf73b2e91f0f67f9 /drivers/video/backlight | |
| parent | backlight: backlight: Introduce backlight_get_brightness() (diff) | |
| download | linux-5a09765ddedd34f176275c72ffbe567e428e2dfc.tar.xz linux-5a09765ddedd34f176275c72ffbe567e428e2dfc.zip | |
backlight: as3711_bl: Simplify update_status
Replaces the open-coded checks of the state, with the
backlight_get_brightness() helper. This increases readability of the
code and align the functionality across the drivers.
Furthermore drop the debug prints in update_status().
If we need debug printing then we can add it to the backlight core.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/video/backlight')
| -rw-r--r-- | drivers/video/backlight/as3711_bl.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/as3711_bl.c index 33f0f0f2e8b3..3b60019cdc2b 100644 --- a/drivers/video/backlight/as3711_bl.c +++ b/drivers/video/backlight/as3711_bl.c @@ -104,17 +104,10 @@ static int as3711_bl_update_status(struct backlight_device *bl) struct as3711_bl_data *data = bl_get_data(bl); struct as3711_bl_supply *supply = to_supply(data); struct as3711 *as3711 = supply->as3711; - int brightness = bl->props.brightness; + int brightness; int ret = 0; - dev_dbg(&bl->dev, "%s(): brightness %u, pwr %x, blank %x, state %x\n", - __func__, bl->props.brightness, bl->props.power, - bl->props.fb_blank, bl->props.state); - - if (bl->props.power != FB_BLANK_UNBLANK || - bl->props.fb_blank != FB_BLANK_UNBLANK || - bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) - brightness = 0; + brightness = backlight_get_brightness(bl); if (data->type == AS3711_BL_SU1) { ret = as3711_set_brightness_v(as3711, brightness, |