diff options
| author | Marijn Suijten <marijn.suijten@somainline.org> | 2021-11-15 21:34:56 +0100 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2021-12-22 12:17:35 +0100 |
| commit | 96571489a06999bf5c62e2058622990734556f8f (patch) | |
| tree | a5141349268e16aecd51a1b82cf26de5cd42c2c0 /drivers/video/backlight | |
| parent | backlight: qcom-wled: Override default length with qcom,enabled-strings (diff) | |
| download | linux-96571489a06999bf5c62e2058622990734556f8f.tar.xz linux-96571489a06999bf5c62e2058622990734556f8f.zip | |
backlight: qcom-wled: Remove unnecessary 4th default string in WLED3
The previous commit improves num_strings parsing to not go over the
maximum of 3 strings for WLED3 anymore. Likewise this default index for
a hypothetical 4th string is invalid and could access registers that are
not mapped to the desired purpose.
Removing this value gets rid of undesired confusion and avoids the
possibility of accessing registers at this offset even if the 4th array
element is used by accident.
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211115203459.1634079-7-marijn.suijten@somainline.org
Diffstat (limited to 'drivers/video/backlight')
| -rw-r--r-- | drivers/video/backlight/qcom-wled.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 5306b06044b4..5c5df5a3deab 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -948,7 +948,7 @@ static const struct wled_config wled3_config_defaults = { .cs_out_en = false, .ext_gen = false, .cabc = false, - .enabled_strings = {0, 1, 2, 3}, + .enabled_strings = {0, 1, 2}, }; static int wled4_setup(struct wled *wled) |