diff options
| author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-18 14:07:53 +0200 |
|---|---|---|
| committer | Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | 2012-09-22 23:41:51 +0200 |
| commit | c24249f5745f426d70c274e7f4dd70f32838c564 (patch) | |
| tree | 074d3252b00c503baf01d99a0a8decce97bddeb2 /drivers/video/cg3.c | |
| parent | drivers/video/sunxvr1000.c: fix error return code (diff) | |
| download | linux-c24249f5745f426d70c274e7f4dd70f32838c564.tar.xz linux-c24249f5745f426d70c274e7f4dd70f32838c564.zip | |
drivers/video/cg3.c: fix error return code
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Diffstat (limited to 'drivers/video/cg3.c')
| -rw-r--r-- | drivers/video/cg3.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/cg3.c b/drivers/video/cg3.c index f927a7b1a8d4..c5e7612ff876 100644 --- a/drivers/video/cg3.c +++ b/drivers/video/cg3.c @@ -398,7 +398,8 @@ static int __devinit cg3_probe(struct platform_device *op) goto out_unmap_screen; } - if (fb_alloc_cmap(&info->cmap, 256, 0)) + err = fb_alloc_cmap(&info->cmap, 256, 0); + if (err) goto out_unmap_screen; fb_set_cmap(&info->cmap, info); |