summaryrefslogtreecommitdiffstats
path: root/drivers/video/fbdev/grvga.c
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2019-06-28 12:30:08 +0200
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2019-06-28 12:30:08 +0200
commit0adcdbcb179624d7b3677264f2cd228e7d89eea9 (patch)
tree72c9a50d59fec3ebfb463604efcb17c198b831de /drivers/video/fbdev/grvga.c
parentvideo: fbdev: intelfb: return -ENOMEM on framebuffer_alloc() failure (diff)
downloadlinux-0adcdbcb179624d7b3677264f2cd228e7d89eea9.tar.xz
linux-0adcdbcb179624d7b3677264f2cd228e7d89eea9.zip
video: fbdev: don't print error message on framebuffer_alloc() failure
framebuffer_alloc() can fail only on kzalloc() memory allocation failure and since kzalloc() will print error message in such case we can omit printing extra error message in drivers (which BTW is what the majority of framebuffer_alloc() users is doing already). Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'drivers/video/fbdev/grvga.c')
-rw-r--r--drivers/video/fbdev/grvga.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/video/fbdev/grvga.c b/drivers/video/fbdev/grvga.c
index df5d546e57e9..d22e8b0c906d 100644
--- a/drivers/video/fbdev/grvga.c
+++ b/drivers/video/fbdev/grvga.c
@@ -336,10 +336,8 @@ static int grvga_probe(struct platform_device *dev)
char *options = NULL, *mode_opt = NULL;
info = framebuffer_alloc(sizeof(struct grvga_par), &dev->dev);
- if (!info) {
- dev_err(&dev->dev, "framebuffer_alloc failed\n");
+ if (!info)
return -ENOMEM;
- }
/* Expecting: "grvga: modestring, [addr:<framebuffer physical address>], [size:<framebuffer size>]
*