summaryrefslogtreecommitdiffstats
path: root/drivers/video/fbdev/i810
diff options
context:
space:
mode:
authorThomas Zimmermann <tzimmermann@suse.de>2023-09-27 09:26:52 +0200
committerThomas Zimmermann <tzimmermann@suse.de>2023-10-19 12:55:32 +0200
commit7e568f77d2c96e05c68a9e141ac4a204c62f4bcd (patch)
treefa8c3cd7a77be797e7cdc3f00bf533abde8188b3 /drivers/video/fbdev/i810
parentfbdev/hpfb: Initialize fb_ops to fbdev I/O-memory helpers (diff)
downloadlinux-7e568f77d2c96e05c68a9e141ac4a204c62f4bcd.tar.xz
linux-7e568f77d2c96e05c68a9e141ac4a204c62f4bcd.zip
fbdev/i810fb: Initialize fb_ops to fbdev I/O-memory helpers
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the callbacks being NULL for a default implementation to be invoked; hence requiring the I/O helpers to be built in any case. Setting all callbacks in all drivers explicitly will allow to make the I/O helpers optional. This benefits systems that do not use these functions. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Javier Martinez Canillas <javierm@redhat.com> Cc: Antonino Daplas <adaplas@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-20-tzimmermann@suse.de
Diffstat (limited to 'drivers/video/fbdev/i810')
-rw-r--r--drivers/video/fbdev/i810/i810_main.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index f5511bb4fadc..d73a795fe1be 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -1547,6 +1547,7 @@ static const struct fb_ops i810fb_ops = {
.owner = THIS_MODULE,
.fb_open = i810fb_open,
.fb_release = i810fb_release,
+ __FB_DEFAULT_IOMEM_OPS_RDWR,
.fb_check_var = i810fb_check_var,
.fb_set_par = i810fb_set_par,
.fb_setcolreg = i810fb_setcolreg,
@@ -1557,6 +1558,7 @@ static const struct fb_ops i810fb_ops = {
.fb_imageblit = i810fb_imageblit,
.fb_cursor = i810fb_cursor,
.fb_sync = i810fb_sync,
+ __FB_DEFAULT_IOMEM_OPS_MMAP,
};
/***********************************************************************