diff options
| author | Thomas Zimmermann <tzimmermann@suse.de> | 2023-04-28 14:24:49 +0200 |
|---|---|---|
| committer | Thomas Zimmermann <tzimmermann@suse.de> | 2023-05-08 15:28:34 +0200 |
| commit | 453bd91302f16ddb8a2f5eb3df9fda3206dbacef (patch) | |
| tree | a126d0ad020c09ca5160b0f50479ebd5aa98fb4c /drivers/video/fbdev/metronomefb.c | |
| parent | fbdev: Use screen_buffer in fb_sys_{read,write}() (diff) | |
| download | linux-453bd91302f16ddb8a2f5eb3df9fda3206dbacef.tar.xz linux-453bd91302f16ddb8a2f5eb3df9fda3206dbacef.zip | |
fbdev: Don't re-validate info->state in fb_ops implementations
The file-op entry points fb_read() and fb_write() verify that
info->state has been set to FBINFO_STATE_RUNNING. Remove the same
test from the implementations of struct fb_ops.{fb_read,fb_write}.
v2:
* also remove test from ivtvfb, braodsheetfb, hecubafb and
metronomefb (Geert)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Sui Jingfeng <suijingfeng@loongson.cn>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230428122452.4856-17-tzimmermann@suse.de
Diffstat (limited to 'drivers/video/fbdev/metronomefb.c')
| -rw-r--r-- | drivers/video/fbdev/metronomefb.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/video/fbdev/metronomefb.c b/drivers/video/fbdev/metronomefb.c index afa9b41f5a87..2bb068cadac6 100644 --- a/drivers/video/fbdev/metronomefb.c +++ b/drivers/video/fbdev/metronomefb.c @@ -523,9 +523,6 @@ static ssize_t metronomefb_write(struct fb_info *info, const char __user *buf, int err = 0; unsigned long total_size; - if (info->state != FBINFO_STATE_RUNNING) - return -EPERM; - total_size = info->fix.smem_len; if (p > total_size) |