diff options
| author | Hyunwoo Kim <imv4bel@gmail.com> | 2022-06-20 16:17:46 +0200 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2022-06-20 20:12:17 +0200 |
| commit | a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7 (patch) | |
| tree | bb8b03e867f3730cc49a0bce5663ad5ddafeb09c /drivers/video/fbdev/pxa3xx-gcu.c | |
| parent | video: fbdev: skeletonfb: Convert to generic power management (diff) | |
| download | linux-a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7.tar.xz linux-a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7.zip | |
video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write
In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of
type int. Then, copy_from_user() may cause a heap overflow because it is used
as the third argument of copy_from_user().
Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video/fbdev/pxa3xx-gcu.c')
| -rw-r--r-- | drivers/video/fbdev/pxa3xx-gcu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 043cc8f9ef1c..c3cd1e1cc01b 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff, struct pxa3xx_gcu_batch *buffer; struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file); - int words = count / 4; + size_t words = count / 4; /* Does not need to be atomic. There's a lock in user space, * but anyhow, this is just for statistics. */ |