diff options
author | Jean-Philippe Brucker <jean-philippe.brucker@arm.com> | 2016-02-15 19:41:33 +0100 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2016-02-26 12:19:55 +0100 |
commit | a1e533ec07d583d01349ef13c0c965b8633e1b91 (patch) | |
tree | e894dd45f130d60347d68993a4ce15c51db81756 /drivers/video/fbdev/sstfb.c | |
parent | Linux 4.5-rc5 (diff) | |
download | linux-a1e533ec07d583d01349ef13c0c965b8633e1b91.tar.xz linux-a1e533ec07d583d01349ef13c0c965b8633e1b91.zip |
fbcon: set a default value to blink interval
Since commit 27a4c827c34ac4256a190cc9d24607f953c1c459
fbcon: use the cursor blink interval provided by vt
two attempts have been made at fixing a possible hang caused by
cursor_timer_handler. That function registers a timer to be triggered at
"jiffies + fbcon_ops.cur_blink_jiffies".
A new case had been encountered during initialisation of clcd-pl11x:
fbcon_fb_registered
do_fbcon_takeover
-> do_register_con_driver
fbcon_startup
(A) add_cursor_timer (with cur_blink_jiffies = 0)
-> do_bind_con_driver
visual_init
fbcon_init
(B) cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms);
If we take an softirq anywhere between A and B (and we do),
cursor_timer_handler executes indefinitely.
Instead of patching all possible paths that lead to this case one at a
time, fix the issue at the source and initialise cur_blink_jiffies to
200ms when allocating fbcon_ops. This was its default value before
aforesaid commit. fbcon_cursor or fbcon_init will refine this value
downstream.
Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: <stable@vger.kernel.org> # v4.2
Tested-by: Scot Doyle <lkml14@scotdoyle.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video/fbdev/sstfb.c')
0 files changed, 0 insertions, 0 deletions