summaryrefslogtreecommitdiffstats
path: root/drivers/video/fbdev
diff options
context:
space:
mode:
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>2014-05-20 23:37:32 +0200
committerTomi Valkeinen <tomi.valkeinen@ti.com>2014-05-23 12:47:31 +0200
commit0c641bff31af7326b51cd39739cfc3a2c060f456 (patch)
tree4e62855538bea5115c07fcad71b08d762d43835d /drivers/video/fbdev
parentvideo: fbdev: grvga.c: Fix for possible null pointer dereference (diff)
downloadlinux-0c641bff31af7326b51cd39739cfc3a2c060f456.tar.xz
linux-0c641bff31af7326b51cd39739cfc3a2c060f456.zip
video: fbdev: s3fb.c: Fix for possible null pointer dereference
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video/fbdev')
-rw-r--r--drivers/video/fbdev/s3fb.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c
index 9a3f8f1c6aab..c43b969e1e23 100644
--- a/drivers/video/fbdev/s3fb.c
+++ b/drivers/video/fbdev/s3fb.c
@@ -1401,9 +1401,10 @@ err_enable_device:
static void s3_pci_remove(struct pci_dev *dev)
{
struct fb_info *info = pci_get_drvdata(dev);
- struct s3fb_info __maybe_unused *par = info->par;
+ struct s3fb_info __maybe_unused *par;
if (info) {
+ par = info->par;
#ifdef CONFIG_MTRR
if (par->mtrr_reg >= 0) {