diff options
| author | Daniel Drake <dsd@laptop.org> | 2010-11-14 15:12:31 +0100 |
|---|---|---|
| committer | Paul Mundt <lethal@linux-sh.org> | 2010-11-17 06:55:46 +0100 |
| commit | ad913da61aeb267ac99a649834a0cb1a963d7ec2 (patch) | |
| tree | f5efa0c8b940b8b50a05d580e58569e85dd28962 /drivers/video/geode | |
| parent | fbcmap: integer overflow bug (diff) | |
| download | linux-ad913da61aeb267ac99a649834a0cb1a963d7ec2.tar.xz linux-ad913da61aeb267ac99a649834a0cb1a963d7ec2.zip | |
lxfb: Program panel v/h sync output polarity correctly
Commit b5c26f97ec4a17c65 introduced some breakage for the OLPC XO-1 laptop,
differences in the output video signal after the patch caused some problems
with the XO's display controller chip.
Reviewing of that commit against the AMD Geode LX Data Book, it seems
that these bits were being set inversely. In both cases, active high
output is denoted by a value of 0. See section 6.8.3.44 of the databook
from February 2009 (Publication ID: 33234H)
Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'drivers/video/geode')
| -rw-r--r-- | drivers/video/geode/lxfb_ops.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/geode/lxfb_ops.c b/drivers/video/geode/lxfb_ops.c index bc35a95e59d4..85ec7f64c42a 100644 --- a/drivers/video/geode/lxfb_ops.c +++ b/drivers/video/geode/lxfb_ops.c @@ -276,10 +276,10 @@ static void lx_graphics_enable(struct fb_info *info) write_fp(par, FP_PT1, 0); temp = FP_PT2_SCRC; - if (info->var.sync & FB_SYNC_HOR_HIGH_ACT) + if (!(info->var.sync & FB_SYNC_HOR_HIGH_ACT)) temp |= FP_PT2_HSP; - if (info->var.sync & FB_SYNC_VERT_HIGH_ACT) + if (!(info->var.sync & FB_SYNC_VERT_HIGH_ACT)) temp |= FP_PT2_VSP; write_fp(par, FP_PT2, temp); |