diff options
| author | Julia Lawall <julia@diku.dk> | 2011-01-02 15:27:42 +0100 |
|---|---|---|
| committer | Paul Mundt <lethal@linux-sh.org> | 2011-01-06 07:46:56 +0100 |
| commit | e045da7d835a28950543f5f10f0cb1905ca9bbaf (patch) | |
| tree | 49b70bb5ec592f2638804943f3c87218340002a5 /drivers/video/hgafb.c | |
| parent | video: imxfb: Fix the maximum value for yres (diff) | |
| download | linux-e045da7d835a28950543f5f10f0cb1905ca9bbaf.tar.xz linux-e045da7d835a28950543f5f10f0cb1905ca9bbaf.zip | |
drivers/video/carminefb.c: improve error handling
This code had an error handling goto to the wrong place, a misplaced
release_mem_region, and a duplicated release_mem_region.
The semantic match that finds the double release_mem_region is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
expression e1,e2,e3;
position p1,p2,p3;
@@
release_mem_region@p1(e1, e2)@p3;
... when != request_mem_region(e1,e2,e3)
release_mem_region(e1, e2)@p2;
@@
expression e <= r.e1,e3;
expression r.e1,e2;
position r.p1,r.p2,r.p3,p!=r.p1;
@@
*release_mem_region(e1, e2)@p3;
... when != e = e3
*release_mem_region@p(e1, e2)@p2;// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions