diff options
| author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-09-18 14:07:52 +0200 |
|---|---|---|
| committer | Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | 2012-09-22 23:41:51 +0200 |
| commit | 6a1e5f85a0b2d926fdcad8e7fd8cab55ef5f3568 (patch) | |
| tree | e6df2665dd30e3f1f10fcb1934007b8c69a27034 /drivers/video/sunxvr1000.c | |
| parent | drivers/video/mb862xx/mb862xxfbdrv.c: fix error return code (diff) | |
| download | linux-6a1e5f85a0b2d926fdcad8e7fd8cab55ef5f3568.tar.xz linux-6a1e5f85a0b2d926fdcad8e7fd8cab55ef5f3568.zip | |
drivers/video/sunxvr1000.c: fix error return code
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Diffstat (limited to 'drivers/video/sunxvr1000.c')
| -rw-r--r-- | drivers/video/sunxvr1000.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/sunxvr1000.c b/drivers/video/sunxvr1000.c index b7f27acaf817..729a50722bdf 100644 --- a/drivers/video/sunxvr1000.c +++ b/drivers/video/sunxvr1000.c @@ -141,8 +141,10 @@ static int __devinit gfb_probe(struct platform_device *op) gp->fb_base = of_ioremap(&op->resource[6], 0, gp->fb_size, "gfb fb"); - if (!gp->fb_base) + if (!gp->fb_base) { + err = -ENOMEM; goto err_release_fb; + } err = gfb_set_fbinfo(gp); if (err) |