diff options
| author | Marijn Suijten <marijn.suijten@somainline.org> | 2021-11-15 21:34:51 +0100 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2021-12-22 12:14:46 +0100 |
| commit | c05b21ebc5bce3ecc78c2c71afd76d92c790a2ac (patch) | |
| tree | e86e44ce98ad925f6a4f532000239530249acc9e /drivers/video | |
| parent | backlight: lp855x: Add support ACPI enumeration (diff) | |
| download | linux-c05b21ebc5bce3ecc78c2c71afd76d92c790a2ac.tar.xz linux-c05b21ebc5bce3ecc78c2c71afd76d92c790a2ac.zip | |
backlight: qcom-wled: Validate enabled string indices in DT
The strings passed in DT may possibly cause out-of-bounds register
accesses and should be validated before use.
Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211115203459.1634079-2-marijn.suijten@somainline.org
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/backlight/qcom-wled.c | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index d094299c2a48..8a42ed89c59c 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -1528,12 +1528,28 @@ static int wled_configure(struct wled *wled) string_len = of_property_count_elems_of_size(dev->of_node, "qcom,enabled-strings", sizeof(u32)); - if (string_len > 0) + if (string_len > 0) { + if (string_len > wled->max_string_count) { + dev_err(dev, "Cannot have more than %d strings\n", + wled->max_string_count); + return -EINVAL; + } + of_property_read_u32_array(dev->of_node, "qcom,enabled-strings", wled->cfg.enabled_strings, sizeof(u32)); + for (i = 0; i < string_len; ++i) { + if (wled->cfg.enabled_strings[i] >= wled->max_string_count) { + dev_err(dev, + "qcom,enabled-strings index %d at %d is out of bounds\n", + wled->cfg.enabled_strings[i], i); + return -EINVAL; + } + } + } + return 0; } |