summaryrefslogtreecommitdiffstats
path: root/drivers/virt/vboxguest
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2018-04-18 15:24:50 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-04-23 13:41:55 +0200
commit19972dd568f8d1e701f8051fcff56562e0551f63 (patch)
treedde712c243c0c17d5220bc4817c404795aa0d0ff /drivers/virt/vboxguest
parentvirt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory (diff)
downloadlinux-19972dd568f8d1e701f8051fcff56562e0551f63.tar.xz
linux-19972dd568f8d1e701f8051fcff56562e0551f63.zip
virt: vbox: Log an error when we fail to get the host version
This was the only error path during probe without a message being logged about what went wrong, this fixes this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/virt/vboxguest')
-rw-r--r--drivers/virt/vboxguest/vboxguest_core.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
index 7411a535fda2..2f3856a95856 100644
--- a/drivers/virt/vboxguest/vboxguest_core.c
+++ b/drivers/virt/vboxguest/vboxguest_core.c
@@ -727,8 +727,10 @@ static int vbg_query_host_version(struct vbg_dev *gdev)
rc = vbg_req_perform(gdev, req);
ret = vbg_status_code_to_errno(rc);
- if (ret)
+ if (ret) {
+ vbg_err("%s error: %d\n", __func__, rc);
goto out;
+ }
snprintf(gdev->host_version, sizeof(gdev->host_version), "%u.%u.%ur%u",
req->major, req->minor, req->build, req->revision);