diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-12-26 14:28:02 +0100 |
|---|---|---|
| committer | Ard Biesheuvel <ardb@kernel.org> | 2024-03-09 11:37:18 +0100 |
| commit | 021bc4b9d7ed8dcc90dc288e59f120fa6e3087dc (patch) | |
| tree | 9f14ddfc2f2269bb7648d9c96a16765d87f6eb58 /drivers/virt | |
| parent | x86/efistub: Remap kernel text read-only before dropping NX attribute (diff) | |
| download | linux-021bc4b9d7ed8dcc90dc288e59f120fa6e3087dc.tar.xz linux-021bc4b9d7ed8dcc90dc288e59f120fa6e3087dc.zip | |
virt: efi_secret: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Diffstat (limited to 'drivers/virt')
| -rw-r--r-- | drivers/virt/coco/efi_secret/efi_secret.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/virt/coco/efi_secret/efi_secret.c b/drivers/virt/coco/efi_secret/efi_secret.c index e700a5ef7043..cd29e66b1543 100644 --- a/drivers/virt/coco/efi_secret/efi_secret.c +++ b/drivers/virt/coco/efi_secret/efi_secret.c @@ -326,16 +326,15 @@ err_unmap: return ret; } -static int efi_secret_remove(struct platform_device *dev) +static void efi_secret_remove(struct platform_device *dev) { efi_secret_securityfs_teardown(dev); efi_secret_unmap_area(); - return 0; } static struct platform_driver efi_secret_driver = { .probe = efi_secret_probe, - .remove = efi_secret_remove, + .remove_new = efi_secret_remove, .driver = { .name = "efi_secret", }, |