summaryrefslogtreecommitdiffstats
path: root/drivers/virtio
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2015-01-12 15:23:37 +0100
committerRusty Russell <rusty@rustcorp.com.au>2015-01-21 06:58:48 +0100
commit2d9becc1e0c6f86e222e1955e39302d304ad274b (patch)
tree00e5dbaa1ce34f85d271dc088262d584178c98b0 /drivers/virtio
parentvirtio/scsi: verify device has config space (diff)
downloadlinux-2d9becc1e0c6f86e222e1955e39302d304ad274b.tar.xz
linux-2d9becc1e0c6f86e222e1955e39302d304ad274b.zip
virtio/balloon: verify device has config space
Some devices might not implement config space access (e.g. remoteproc used not to - before 3.9). virtio/balloon needs config space access so make it fail gracefully if not there. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/virtio')
-rw-r--r--drivers/virtio/virtio_balloon.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 50c5f42d7a9f..3176ea4028a8 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -466,6 +466,12 @@ static int virtballoon_probe(struct virtio_device *vdev)
struct virtio_balloon *vb;
int err;
+ if (!vdev->config->get) {
+ dev_err(&vdev->dev, "%s failure: config access disabled\n",
+ __func__);
+ return -EINVAL;
+ }
+
vdev->priv = vb = kmalloc(sizeof(*vb), GFP_KERNEL);
if (!vb) {
err = -ENOMEM;