diff options
author | Michael J. Ruhl <michael.j.ruhl@intel.com> | 2017-12-19 04:57:21 +0100 |
---|---|---|
committer | Doug Ledford <dledford@redhat.com> | 2018-01-05 19:34:55 +0100 |
commit | 11f0e89710ebea7d1086cbe9ab1270c96677f1dc (patch) | |
tree | dc9152e3cbb4a42a41684cdf74b3654bf361c2cb /drivers/virtio | |
parent | IB/rdmavt: Allocate CQ memory on the correct node (diff) | |
download | linux-11f0e89710ebea7d1086cbe9ab1270c96677f1dc.tar.xz linux-11f0e89710ebea7d1086cbe9ab1270c96677f1dc.zip |
IB/{hfi1, qib}: Fix a concurrency issue with device name in logging
The get_unit_name() function crafts a string based on the device name
and the device unit number. It then stores this in a static variable.
This has concurrency issues as can be seen with this log:
hfi1 0000:02:00.0: hfi1_1: read_idle_message: read idle message 0x203
hfi1 0000:01:00.0: hfi1_1: read_idle_message: read idle message 0x203
The PCI device ID (0000:02:00.0 vs. 0000:01:00.0) is correct for the
message, but the device string hfi1_1 is incorrect (it should be
hfi1_0 for the second log message).
Remove get_unit_name() function.
Instead, use the rvt accessor rvt_get_ibdev_name() to get the IB name
string.
Clean up any hfi1_early_xx calls that can now use the new path.
QIB has the same (qib_get_unit_name()) issue. Updating as necessary.
Remove qib_get_unit_name() function.
Update log message that has redundant device name.
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/virtio')
0 files changed, 0 insertions, 0 deletions