diff options
author | Seiji Aguchi <seiji.aguchi@hds.com> | 2013-01-11 19:10:05 +0100 |
---|---|---|
committer | Tony Luck <tony.luck@intel.com> | 2013-01-11 19:21:56 +0100 |
commit | e59310adf5eebce108f78b6c47bb330aae2e1666 (patch) | |
tree | 755e6f7348fd37094a856595f4ab33ffc5635ce2 /drivers/watchdog/txx9wdt.c | |
parent | pstore: Avoid deadlock in panic and emergency-restart path (diff) | |
download | linux-e59310adf5eebce108f78b6c47bb330aae2e1666.tar.xz linux-e59310adf5eebce108f78b6c47bb330aae2e1666.zip |
efi_pstore: Avoid deadlock in non-blocking paths
[Issue]
There is a scenario which efi_pstore may hang up:
- cpuA grabs efivars->lock
- cpuB panics and calls smp_send_stop
- smp_send_stop sends IRQ to cpuA
- after 1 second, cpuB gives up on cpuA and sends an NMI instead
- cpuA is now in an NMI handler while still holding efivars->lock
- cpuB is deadlocked
This case may happen if a firmware has a bug and
cpuA is stuck talking with it.
[Solution]
This patch changes a spin_lock to a spin_trylock in non-blocking paths.
and if the spin_lock has already taken by another cpu,
it returns without accessing to a firmware to avoid the deadlock.
Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'drivers/watchdog/txx9wdt.c')
0 files changed, 0 insertions, 0 deletions