diff options
| author | Insu Yun <wuninsu@gmail.com> | 2016-01-18 17:54:43 +0100 |
|---|---|---|
| committer | David Vrabel <david.vrabel@citrix.com> | 2016-02-15 14:56:57 +0100 |
| commit | 85c0a87cd117e83361932b2b160c9af178fdb21a (patch) | |
| tree | 3f29931c9be46cb4ed83c1bf75cf05b85293e2fd /drivers/xen/xenbus | |
| parent | xen/arm: correctly handle DMA mapping of compound pages (diff) | |
| download | linux-85c0a87cd117e83361932b2b160c9af178fdb21a.tar.xz linux-85c0a87cd117e83361932b2b160c9af178fdb21a.zip | |
xen: fix potential integer overflow in queue_reply
When len is greater than UINT_MAX - sizeof(*rb), in next allocation,
it can overflow integer range and allocates small size of heap.
After that, memcpy will overflow the allocated heap.
Therefore, it needs to check the size of given length.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Diffstat (limited to 'drivers/xen/xenbus')
| -rw-r--r-- | drivers/xen/xenbus/xenbus_dev_frontend.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c index 9433e46518c8..912b64edb42b 100644 --- a/drivers/xen/xenbus/xenbus_dev_frontend.c +++ b/drivers/xen/xenbus/xenbus_dev_frontend.c @@ -188,6 +188,8 @@ static int queue_reply(struct list_head *queue, const void *data, size_t len) if (len == 0) return 0; + if (len > XENSTORE_PAYLOAD_MAX) + return -EINVAL; rb = kmalloc(sizeof(*rb) + len, GFP_KERNEL); if (rb == NULL) |