summaryrefslogtreecommitdiffstats
path: root/drivers/xen
diff options
context:
space:
mode:
authorKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>2013-12-04 03:37:24 +0100
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>2014-05-23 18:33:36 +0200
commitfcb8ce968fb5d476cbb3f1547ade0c05fc2f6c59 (patch)
tree1d38e922c6f61d4dc0c3cd4057cd1bf92f6eaf14 /drivers/xen
parentxen-pciback: Cleanup up pcistub_put_pci_dev (diff)
downloadlinux-fcb8ce968fb5d476cbb3f1547ade0c05fc2f6c59.tar.xz
linux-fcb8ce968fb5d476cbb3f1547ade0c05fc2f6c59.zip
xen-pciback: First reset, then free.
We were doing the operations of freeing and reset in the wrong order. Granted nothing broke because the reset functions just set bar->which = 0. But nonethless this was incorrect. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
Diffstat (limited to 'drivers/xen')
-rw-r--r--drivers/xen/xen-pciback/pci_stub.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index 5300a216896d..36dd4f3685f0 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -278,8 +278,8 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
xen_pcibk_reset_device(dev);
/* And cleanup up our emulated fields. */
- xen_pcibk_config_free_dyn_fields(dev);
xen_pcibk_config_reset_dev(dev);
+ xen_pcibk_config_free_dyn_fields(dev);
xen_unregister_device_domain_owner(dev);