summaryrefslogtreecommitdiffstats
path: root/drivers/xen
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2011-11-04 19:24:36 +0100
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>2011-11-16 18:13:48 +0100
commit99cb2ddcc617f43917e94a4147aa3ccdb2bcd77e (patch)
tree2c2f3a0271dc0e2b627eb45823c03a10bbce3002 /drivers/xen
parentxen-gntalloc: integer overflow in gntalloc_ioctl_alloc() (diff)
downloadlinux-99cb2ddcc617f43917e94a4147aa3ccdb2bcd77e.tar.xz
linux-99cb2ddcc617f43917e94a4147aa3ccdb2bcd77e.zip
xen-gntalloc: signedness bug in add_grefs()
gref->gref_id is unsigned so the error handling didn't work. gnttab_grant_foreign_access() returns an int type, so we can add a cast here, and it doesn't cause any problems. gnttab_grant_foreign_access() can return a variety of errors including -ENOSPC, -ENOSYS and -ENOMEM. CC: stable@kernel.org Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'drivers/xen')
-rw-r--r--drivers/xen/gntalloc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c
index 23c60cf4313e..e1c4c6e5b469 100644
--- a/drivers/xen/gntalloc.c
+++ b/drivers/xen/gntalloc.c
@@ -135,7 +135,7 @@ static int add_grefs(struct ioctl_gntalloc_alloc_gref *op,
/* Grant foreign access to the page. */
gref->gref_id = gnttab_grant_foreign_access(op->domid,
pfn_to_mfn(page_to_pfn(gref->page)), readonly);
- if (gref->gref_id < 0) {
+ if ((int)gref->gref_id < 0) {
rc = gref->gref_id;
goto undo;
}