summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-11-27 14:43:27 +0100
committerKalle Valo <kvalo@codeaurora.org>2015-11-30 13:58:59 +0100
commit7941c2129a4bc189e17e3188a7d315d946caa1d6 (patch)
treec3dc893f6d3f52a3743ce058d0cdcf49ff5c3b24 /drivers
parentlibertas: cleanup a variable name (diff)
downloadlinux-7941c2129a4bc189e17e3188a7d315d946caa1d6.tar.xz
linux-7941c2129a4bc189e17e3188a7d315d946caa1d6.zip
brcm80211: fix error code in brcmf_pcie_exit_download_state()
The original code returns 1 on failure and 0 on success but the caller was expecting an error code on failure. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to '')
-rw-r--r--drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index ace0404817dc..b5a4247604f3 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -609,7 +609,9 @@ static int brcmf_pcie_exit_download_state(struct brcmf_pciedev_info *devinfo,
brcmf_chip_resetcore(core, 0, 0, 0);
}
- return !brcmf_chip_set_active(devinfo->ci, resetintr);
+ if (!brcmf_chip_set_active(devinfo->ci, resetintr))
+ return -EINVAL;
+ return 0;
}