diff options
| author | Nicholas Mc Guire <hofrat@osadl.org> | 2016-07-23 21:31:20 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2016-07-24 22:49:16 +0200 |
| commit | 57c2b0ddd14d8831cbaab855373fe8797812ea53 (patch) | |
| tree | 897092bd8422cac43b0dd933581bfe2908911bc5 /drivers | |
| parent | Linux 4.7 (diff) | |
| download | linux-57c2b0ddd14d8831cbaab855373fe8797812ea53.tar.xz linux-57c2b0ddd14d8831cbaab855373fe8797812ea53.zip | |
spi: pic32: fixup wait_for_completion_timeout return handling
wait_for_completion_timeout returns unsigned long not int so the check for
<= 0 should be == 0 here.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/spi/spi-pic32.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c index 73db87f805a1..fefb688a3432 100644 --- a/drivers/spi/spi-pic32.c +++ b/drivers/spi/spi-pic32.c @@ -507,6 +507,7 @@ static int pic32_spi_one_transfer(struct spi_master *master, { struct pic32_spi *pic32s; bool dma_issued = false; + unsigned long timeout; int ret; pic32s = spi_master_get_devdata(master); @@ -553,8 +554,8 @@ static int pic32_spi_one_transfer(struct spi_master *master, } /* wait for completion */ - ret = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ); - if (ret <= 0) { + timeout = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ); + if (timeout == 0) { dev_err(&spi->dev, "wait error/timedout\n"); if (dma_issued) { dmaengine_terminate_all(master->dma_rx); |