summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAdrian Bunk <bunk@stusta.de>2005-11-27 00:37:36 +0100
committerLinus Torvalds <torvalds@g5.osdl.org>2005-11-28 05:23:13 +0100
commit2012a116d9e6803fb072d0cfe1aae0cc4e6d6416 (patch)
treebb9d851ae660c92edb710909746eb414c8d586e0 /drivers
parent[PATCH] drivers/message/i2o/pci.c: fix a NULL pointer dereference (diff)
downloadlinux-2012a116d9e6803fb072d0cfe1aae0cc4e6d6416.tar.xz
linux-2012a116d9e6803fb072d0cfe1aae0cc4e6d6416.zip
[PATCH] drivers/infiniband/core/mad.c: fix use-after-release case
The Coverity checker spotted this obvious use-after-release bug caused by a wrong order of the cleanups. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/infiniband/core/mad.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index 41d6b4017acb..d393b504bf26 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -355,9 +355,9 @@ error4:
spin_unlock_irqrestore(&port_priv->reg_lock, flags);
kfree(reg_req);
error3:
- kfree(mad_agent_priv);
-error2:
ib_dereg_mr(mad_agent_priv->agent.mr);
+error2:
+ kfree(mad_agent_priv);
error1:
return ret;
}