diff options
| author | Rafal Prylowski <prylowski@metasoft.pl> | 2012-05-28 17:35:54 +0200 |
|---|---|---|
| committer | Bryan Wu <bryan.wu@canonical.com> | 2012-06-12 04:56:24 +0200 |
| commit | 3fbd8716da4c69ddbb76c022f3f4a0d50723c68f (patch) | |
| tree | 052b895fc8290e7756a3492fc1fada0c65cce808 /drivers | |
| parent | Linux 3.5-rc2 (diff) | |
| download | linux-3fbd8716da4c69ddbb76c022f3f4a0d50723c68f.tar.xz linux-3fbd8716da4c69ddbb76c022f3f4a0d50723c68f.zip | |
leds: don't disable blinking when writing the same value to delay_on or delay_off
Function led_set_software_blink() assumes that blink timer is still running,
but commit 488bc35bf40df89d37486c1826b178a2fba36ce7 introduced disabling
of blink timer before each call to led_set_software_blink().
Correct led_software_blink():
1) remove protection against reprogramming blink timer to the same values,
because it only disables blinking now,
2) remove unnecessary call to led_stop_software_blink().
Signed-off-by: Rafal Prylowski <prylowski@metasoft.pl>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/leds/led-core.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index d6860043f6f9..d65353d8d3fc 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -44,13 +44,6 @@ static void led_set_software_blink(struct led_classdev *led_cdev, if (!led_cdev->blink_brightness) led_cdev->blink_brightness = led_cdev->max_brightness; - if (led_get_trigger_data(led_cdev) && - delay_on == led_cdev->blink_delay_on && - delay_off == led_cdev->blink_delay_off) - return; - - led_stop_software_blink(led_cdev); - led_cdev->blink_delay_on = delay_on; led_cdev->blink_delay_off = delay_off; |