diff options
| author | Adrian Bunk <bunk@kernel.org> | 2008-04-14 16:20:04 +0200 |
|---|---|---|
| committer | David Woodhouse <dwmw2@infradead.org> | 2008-04-22 16:55:38 +0200 |
| commit | ed262c4f5cb8291668c27c88a022bd7628f067a4 (patch) | |
| tree | a86fd8198b0fae7f2ca2a83b172a1f5b5c94970b /drivers | |
| parent | [MTD] mtdram.c should #include <linux/mtd/mtdram.h> (diff) | |
| download | linux-ed262c4f5cb8291668c27c88a022bd7628f067a4.tar.xz linux-ed262c4f5cb8291668c27c88a022bd7628f067a4.zip | |
[MTD] cmdlinepart.c: don't compare pointers with 0
Sparse spotted that 0 was compared to pointers.
While I was at it, I also moved the assignments out of the if's.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mtd/cmdlinepart.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c index b44292abd9f7..3e090436396d 100644 --- a/drivers/mtd/cmdlinepart.c +++ b/drivers/mtd/cmdlinepart.c @@ -119,7 +119,8 @@ static struct mtd_partition * newpart(char *s, char *p; name = ++s; - if ((p = strchr(name, delim)) == 0) + p = strchr(name, delim); + if (!p) { printk(KERN_ERR ERRP "no closing %c found in partition name\n", delim); return NULL; @@ -159,9 +160,10 @@ static struct mtd_partition * newpart(char *s, return NULL; } /* more partitions follow, parse them */ - if ((parts = newpart(s + 1, &s, num_parts, - this_part + 1, &extra_mem, extra_mem_size)) == 0) - return NULL; + parts = newpart(s + 1, &s, num_parts, this_part + 1, + &extra_mem, extra_mem_size); + if (!parts) + return NULL; } else { /* this is the last partition: allocate space for all */ |