diff options
| author | Oliver Neukum <oneukum@suse.de> | 2007-03-20 13:15:05 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-04-27 22:28:37 +0200 |
| commit | 4f93b3e8212df43ff380e118aebb68f6d1e5b060 (patch) | |
| tree | 228ed1060a8d24a18557852ccba1805d36ffd73f /drivers | |
| parent | UHCI: Add some WARN_ON()s (diff) | |
| download | linux-4f93b3e8212df43ff380e118aebb68f6d1e5b060.tar.xz linux-4f93b3e8212df43ff380e118aebb68f6d1e5b060.zip | |
USB: omninet memory leak in error case
memory allocated must be freed in the error case.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/serial/omninet.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c index 0216ac12a27d..357cc11915cf 100644 --- a/drivers/usb/serial/omninet.c +++ b/drivers/usb/serial/omninet.c @@ -170,8 +170,12 @@ static int omninet_open (struct usb_serial_port *port, struct file *filp) port->read_urb->transfer_buffer, port->read_urb->transfer_buffer_length, omninet_read_bulk_callback, port); result = usb_submit_urb(port->read_urb, GFP_KERNEL); - if (result) + if (result) { err("%s - failed submitting read urb, error %d", __FUNCTION__, result); + /* open failed - all allocations must be freed */ + kfree(od); + usb_set_serial_port_data(port, NULL); + } return result; } |