summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorVladimir Zapolskiy <vladimir_zapolskiy@mentor.com>2013-10-28 18:05:15 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-10-30 00:24:33 +0100
commit7c65e29250a3154cac18b527b6ccfc61f8f08c58 (patch)
treed9f6f559b4f85249eba7b59b30aed91a905bf9ec /drivers
parentmisc/93xx46: avoid infinite loop on write() (diff)
downloadlinux-7c65e29250a3154cac18b527b6ccfc61f8f08c58.tar.xz
linux-7c65e29250a3154cac18b527b6ccfc61f8f08c58.zip
misc/at24: avoid infinite loop on write()
This change fixes a problem of infinite zero byte write() without an error status, if there is an attempt to write a file bigger than EEPROM size over sysfs interface. Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Cc: Wolfram Sang <w.sang@pengutronix.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/misc/eeprom/at24.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 5d4fd69d04ca..94b8a3324319 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -428,6 +428,9 @@ static ssize_t at24_bin_write(struct file *filp, struct kobject *kobj,
{
struct at24_data *at24;
+ if (unlikely(off >= attr->size))
+ return -EFBIG;
+
at24 = dev_get_drvdata(container_of(kobj, struct device, kobj));
return at24_write(at24, buf, off, count);
}