diff options
| author | Nickolai Zeldovich <nickolai@csail.mit.edu> | 2013-01-05 20:17:45 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-07 22:53:28 +0100 |
| commit | ae428655b826f2755a8101b27beda42a275ef8ad (patch) | |
| tree | 2ecb6794a2d0f8987ac2cfc7397f8851ffb84eec /drivers | |
| parent | staging: rtl8192e: Fix failure to check pci_map_single() (diff) | |
| download | linux-ae428655b826f2755a8101b27beda42a275ef8ad.tar.xz linux-ae428655b826f2755a8101b27beda42a275ef8ad.zip | |
staging: speakup: avoid out-of-range access in synth_init()
Check that array index is in-bounds before accessing the synths[] array.
Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: stable <stable@vger.kernel.org>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/speakup/synth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index df9533798095..b91d22b6330f 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -342,7 +342,7 @@ int synth_init(char *synth_name) mutex_lock(&spk_mutex); /* First, check if we already have it loaded. */ - for (i = 0; synths[i] != NULL && i < MAXSYNTHS; i++) + for (i = 0; i < MAXSYNTHS && synths[i] != NULL; i++) if (strcmp(synths[i]->name, synth_name) == 0) synth = synths[i]; |