diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2008-07-10 13:54:57 +0200 |
|---|---|---|
| committer | Neil Brown <neilb@suse.de> | 2008-07-10 07:25:18 +0200 |
| commit | 7a1fc53c5adb910751a9b212af90302eb4ffb527 (patch) | |
| tree | 9006ecc4323f2a55e6e16f2e19e41ec3c4c3a1ea /drivers | |
| parent | Fix error paths if md_probe fails. (diff) | |
| download | linux-7a1fc53c5adb910751a9b212af90302eb4ffb527.tar.xz linux-7a1fc53c5adb910751a9b212af90302eb4ffb527.zip | |
md: ensure all blocks are uptodate or locked when syncing
Remove the dubious attempt to prefer 'compute' over 'read'. Not only is it
wrong given commit c337869d (md: do not compute parity unless it is on a failed
drive), but it can trigger a BUG_ON in handle_parity_checks5().
Cc: <stable@kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Neil Brown <neilb@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/md/raid5.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 54c8ee28fcc4..3b27df52456b 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -2017,12 +2017,7 @@ static int __handle_issuing_new_read_requests5(struct stripe_head *sh, */ s->uptodate++; return 0; /* uptodate + compute == disks */ - } else if ((s->uptodate < disks - 1) && - test_bit(R5_Insync, &dev->flags)) { - /* Note: we hold off compute operations while checks are - * in flight, but we still prefer 'compute' over 'read' - * hence we only read if (uptodate < * disks-1) - */ + } else if (test_bit(R5_Insync, &dev->flags)) { set_bit(R5_LOCKED, &dev->flags); set_bit(R5_Wantread, &dev->flags); if (!test_and_set_bit(STRIPE_OP_IO, &sh->ops.pending)) |