diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2014-11-27 12:29:24 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2014-12-09 11:05:23 +0100 |
| commit | 0ffaeadfc451a11b5da35578b2f9b977f9f46489 (patch) | |
| tree | 930739568abe771406bd9e9a01c11c8707958f42 /drivers | |
| parent | virtio: use u32, not bitmap for features (diff) | |
| download | linux-0ffaeadfc451a11b5da35578b2f9b977f9f46489.tar.xz linux-0ffaeadfc451a11b5da35578b2f9b977f9f46489.zip | |
mic_virtio: robust feature array size calculation
mic reads sizeof(vdev->features) bits from device, but in fact it stores
bits in local features variable. use sizeof(features) to make code
robust against future changes extending sizeof(vdev->features).
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/misc/mic/card/mic_virtio.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/misc/mic/card/mic_virtio.c b/drivers/misc/mic/card/mic_virtio.c index 4f070ad1875c..d5da9ff646cb 100644 --- a/drivers/misc/mic/card/mic_virtio.c +++ b/drivers/misc/mic/card/mic_virtio.c @@ -76,8 +76,7 @@ static u32 mic_get_features(struct virtio_device *vdev) u8 __iomem *in_features = mic_vq_features(desc); int feature_len = ioread8(&desc->feature_len); - bits = min_t(unsigned, feature_len, - sizeof(vdev->features)) * 8; + bits = min_t(unsigned, feature_len, sizeof(features)) * 8; for (i = 0; i < bits; i++) if (ioread8(&in_features[i / 8]) & (BIT(i % 8))) features |= BIT(i); |