diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2017-02-20 17:15:46 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2017-03-16 21:52:11 +0100 |
| commit | 4ed55016d763325887461d43d0aec4010adcab65 (patch) | |
| tree | f041f339bfb5ec9c6d0565c4c85a3e55663ff85d /drivers | |
| parent | gpio: xlp: Update for ARCH_THUNDER2 (diff) | |
| download | linux-4ed55016d763325887461d43d0aec4010adcab65.tar.xz linux-4ed55016d763325887461d43d0aec4010adcab65.zip | |
gpio: acpi: Don't return 0 on acpi_gpio_count()
It's unusual to have error checking like (ret <= 0) in cases when
counting GPIO resources. In case when it's mandatory we propagate the
error (-ENOENT), otherwise we don't use the result.
This makes consistent behaviour across all possible variants called in
gpiod_count().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpio/gpiolib-acpi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 108331de440b..a5b84d40e60c 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1098,7 +1098,7 @@ int acpi_gpio_count(struct device *dev, const char *con_id) break; } } - if (count >= 0) + if (count > 0) break; } @@ -1114,7 +1114,7 @@ int acpi_gpio_count(struct device *dev, const char *con_id) if (crs_count > 0) count = crs_count; } - return count; + return count ? count : -ENOENT; } struct acpi_crs_lookup { |