diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2017-08-08 06:52:34 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-08-08 12:36:35 +0200 |
| commit | ba8afe94723e9ba665aee9cca649fb2c80f7304c (patch) | |
| tree | 0996f7090dde8fcd62c6e540e3373d54d521282a /drivers | |
| parent | Linux v4.13-rc1 (diff) | |
| download | linux-ba8afe94723e9ba665aee9cca649fb2c80f7304c.tar.xz linux-ba8afe94723e9ba665aee9cca649fb2c80f7304c.zip | |
spi/bcm63xx: fix error return code in bcm63xx_spi_probe()
platform_get_irq() returns an error code, but the spi-bcm63xx driver
ignores it and always returns -ENXIO. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/spi/spi-bcm63xx.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index 84c7356ce5b4..bfe5754768f9 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -530,8 +530,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(dev, "no irq\n"); - return -ENXIO; + dev_err(dev, "no irq: %d\n", irq); + return irq; } clk = devm_clk_get(dev, "spi"); |