diff options
| author | Eric Dumazet <edumazet@google.com> | 2017-01-19 08:03:08 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-20 18:41:46 +0100 |
| commit | e048fc50d7bde23136e098e04a324d7e3404408d (patch) | |
| tree | 942be3963c8a58d2fa891a7d043d34b69e07ea89 /drivers | |
| parent | bpf: fix samples xdp_tx_iptunnel and tc_l2_redirect with fake KBUILD_MODNAME (diff) | |
| download | linux-e048fc50d7bde23136e098e04a324d7e3404408d.tar.xz linux-e048fc50d7bde23136e098e04a324d7e3404408d.zip | |
net/mlx5e: Do not recycle pages from emergency reserve
A driver using dev_alloc_page() must not reuse a page allocated from
emergency memory reserve.
Otherwise all packets using this page will be immediately dropped,
unless for very specific sockets having SOCK_MEMALLOC bit set.
This issue might be hard to debug, because only a fraction of received
packets would be dropped.
Fixes: 4415a0319f92 ("net/mlx5e: Implement RX mapped page cache for page recycle")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 0e2fb3ed1790..06d5e6fecb0a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -193,6 +193,9 @@ static inline bool mlx5e_rx_cache_put(struct mlx5e_rq *rq, return false; } + if (unlikely(page_is_pfmemalloc(dma_info->page))) + return false; + cache->page_cache[cache->tail] = *dma_info; cache->tail = tail_next; return true; |