diff options
| author | Alexandre Belloni <alexandre.belloni@free-electrons.com> | 2013-10-16 16:08:31 +0200 |
|---|---|---|
| committer | Anton Vorontsov <anton@enomsg.org> | 2013-10-26 01:24:22 +0200 |
| commit | 3ed5cd79b82e9a055e0df3275eeb471ea0f1e2d7 (patch) | |
| tree | 6cb58a324dc8c0123171da4d1647a8e5422b360d /drivers | |
| parent | tps65090-charger: Use "IS_ENABLED(CONFIG_OF)" for DT code (diff) | |
| download | linux-3ed5cd79b82e9a055e0df3275eeb471ea0f1e2d7.tar.xz linux-3ed5cd79b82e9a055e0df3275eeb471ea0f1e2d7.zip | |
bq2415x_charger: Fix max battery regulation voltage
As per the datasheets, maximum battery regulation voltage is 4440mV.
The formula is (voltage - offset) / step, so the maximum value is:
(4440 - 3500) / 20 = 47
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Thanks-to: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/power/bq2415x_charger.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c index 0727f9256138..df893dd1447d 100644 --- a/drivers/power/bq2415x_charger.c +++ b/drivers/power/bq2415x_charger.c @@ -605,9 +605,13 @@ static int bq2415x_set_battery_regulation_voltage(struct bq2415x_device *bq, { int val = (mV/10 - 350) / 2; + /* + * According to datasheet, maximum battery regulation voltage is + * 4440mV which is b101111 = 47. + */ if (val < 0) val = 0; - else if (val > 94) /* FIXME: Max is 94 or 122 ? Set max value ? */ + else if (val > 47) return -EINVAL; return bq2415x_i2c_write_mask(bq, BQ2415X_REG_VOLTAGE, val, |