diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-03-02 22:07:24 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-03 10:04:39 +0100 |
| commit | 4d27b87785a743fdae653d395a3a4e763269c53c (patch) | |
| tree | 6d2458620d07a9c34b91c9814bafbca3fc91f3a3 /drivers | |
| parent | cassini: fix off by one (diff) | |
| download | linux-4d27b87785a743fdae653d395a3a4e763269c53c.tar.xz linux-4d27b87785a743fdae653d395a3a4e763269c53c.zip | |
davinci_emac: off by one
This off by one error was found by smatch.
drivers/net/davinci_emac.c +2390 emac_dev_open(13) error: buffer overflow 'priv->mac_addr' 6 <= 6
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/davinci_emac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index 1ac9440eb3fb..32960b9b02ae 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c @@ -2385,7 +2385,7 @@ static int emac_dev_open(struct net_device *ndev) struct emac_priv *priv = netdev_priv(ndev); netif_carrier_off(ndev); - for (cnt = 0; cnt <= ETH_ALEN; cnt++) + for (cnt = 0; cnt < ETH_ALEN; cnt++) ndev->dev_addr[cnt] = priv->mac_addr[cnt]; /* Configuration items */ |