summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorJames Morse <james.morse@arm.com>2018-12-21 20:25:19 +0100
committerWill Deacon <will.deacon@arm.com>2019-01-03 19:03:54 +0100
commitacafce48b07bf5f9994a38e7fe237193d43d092e (patch)
tree441a12c76bc4301d9ff457d3cd002bab14715dce /drivers
parentfirmware: arm_sdei: fix wrong of_node_put() in init function (diff)
downloadlinux-acafce48b07bf5f9994a38e7fe237193d43d092e.tar.xz
linux-acafce48b07bf5f9994a38e7fe237193d43d092e.zip
firmware: arm_sdei: Fix DT platform device creation
It turns out the dt-probing part of this wasn't tested properly after it was merged. commit 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") changed the core-code to generate the platform devices, meaning the driver's attempt fails, and it bails out. Fix this by removing the manual platform-device creation for DT systems, core code has always done this for us. CC: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Signed-off-by: James Morse <james.morse@arm.com> Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/firmware/arm_sdei.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
index dffb47c6b480..c64c7da73829 100644
--- a/drivers/firmware/arm_sdei.c
+++ b/drivers/firmware/arm_sdei.c
@@ -1009,7 +1009,6 @@ static struct platform_driver sdei_driver = {
static bool __init sdei_present_dt(void)
{
- struct platform_device *pdev;
struct device_node *np, *fw_np;
fw_np = of_find_node_by_name(NULL, "firmware");
@@ -1019,11 +1018,7 @@ static bool __init sdei_present_dt(void)
np = of_find_matching_node(fw_np, sdei_of_match);
if (!np)
return false;
-
- pdev = of_platform_device_create(np, sdei_driver.driver.name, NULL);
of_node_put(np);
- if (!pdev)
- return false;
return true;
}