diff options
| author | Petros Koutoupis <petros@petroskoutoupis.com> | 2017-10-30 22:38:10 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-11-03 16:23:30 +0100 |
| commit | ad95028a2e88e59fadda79141e74546d12ba3b4b (patch) | |
| tree | 6b88a04ae7cfe6df25f2a23543b14ad24fed0653 /drivers | |
| parent | scsi: scsi_debug: write_same: fix error report (diff) | |
| download | linux-ad95028a2e88e59fadda79141e74546d12ba3b4b.tar.xz linux-ad95028a2e88e59fadda79141e74546d12ba3b4b.zip | |
scsi: scsi_error: DID_SOFT_ERROR comment clean up
Updated comment. We are keeping track of maximum number of retries per
command via retries/allowed in struct scsi_cmnd. Corrected comment
positioning.
[mkp: applied by hand]
Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/scsi/scsi_error.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index d670027f598f..ae0486332ea8 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -1753,16 +1753,12 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd) * that it indicates SUCCESS. */ return SUCCESS; + case DID_SOFT_ERROR: /* * when the low level driver returns did_soft_error, * it is responsible for keeping an internal retry counter * in order to avoid endless loops (db) - * - * actually this is a bug in this function here. we should - * be mindful of the maximum number of retries specified - * and not get stuck in a loop. */ - case DID_SOFT_ERROR: goto maybe_retry; case DID_IMM_RETRY: return NEEDS_RETRY; |