summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2020-07-23 14:33:26 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-07-24 10:44:27 +0200
commitde5b2c9d16924ad0d9e2bfd9a5da16fe6ea54f22 (patch)
tree9dd12d4395b366956764af5a7fb49cdd39306712 /drivers
parentnewport_con: vc_color is now in state (diff)
downloadlinux-de5b2c9d16924ad0d9e2bfd9a5da16fe6ea54f22.tar.xz
linux-de5b2c9d16924ad0d9e2bfd9a5da16fe6ea54f22.zip
serial: pmac_zilog: add sparse context annotation
Add sparse context annotation to the receive handler, which releases and reacquires the port lock, to silence a sparse warning: drivers/tty/serial/pmac_zilog.c:255:36: sparse: sparse: context imbalance in 'pmz_receive_chars' - unexpected unlock Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20200723123327.5843-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/tty/serial/pmac_zilog.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
index ba65a3bbd72a..96e7aa479961 100644
--- a/drivers/tty/serial/pmac_zilog.c
+++ b/drivers/tty/serial/pmac_zilog.c
@@ -213,6 +213,7 @@ static void pmz_interrupt_control(struct uart_pmac_port *uap, int enable)
}
static bool pmz_receive_chars(struct uart_pmac_port *uap)
+ __must_hold(&uap->port.lock)
{
struct tty_port *port;
unsigned char ch, r1, drop, flag;