diff options
| author | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2016-04-20 18:39:20 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2016-04-20 18:40:07 +0200 |
| commit | 13431509a41889a70cc76b31180f63fd10d0a5b3 (patch) | |
| tree | 775d71912dbc7d6b44a876e5b10b523775f35ff9 /drivers | |
| parent | [media] media: Support Intersil/Techwell TW686x-based video capture cards (diff) | |
| download | linux-13431509a41889a70cc76b31180f63fd10d0a5b3.tar.xz linux-13431509a41889a70cc76b31180f63fd10d0a5b3.zip | |
[media] tw686x-kh: use the cached value
the dma_requests field is cached, but cache is not used:
drivers/staging/media/tw686x-kh/tw686x-kh-video.c: In function 'tw686x_video_irq':
drivers/staging/media/tw686x-kh/tw686x-kh-video.c:622:6: warning: variable 'requests' set but not used [-Wunused-but-set-variable]
u32 requests;
^
Use the cache instead, as it seems reading it needs to be done
with spin lock taken.
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c index 2fbc3cbd9eb0..0650c29f78eb 100644 --- a/drivers/staging/media/tw686x-kh/tw686x-kh-video.c +++ b/drivers/staging/media/tw686x-kh/tw686x-kh-video.c @@ -625,7 +625,7 @@ int tw686x_video_irq(struct tw686x_dev *dev) requests = dev->dma_requests; spin_unlock_irqrestore(&dev->irq_lock, flags); - if (dev->dma_requests & dev->video_active) { + if (requests & dev->video_active) { wake_up_interruptible_all(&dev->video_thread_wait); handled = 1; } |