summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorRohit Maheshwari <rohitm@chelsio.com>2020-11-09 11:51:39 +0100
committerJakub Kicinski <kuba@kernel.org>2020-11-12 01:30:38 +0100
commit659bf0383d15b07e492e27443d87736b24171558 (patch)
treeb49efe8ba780d17b6b0ff3e91828ca469e043cd1 /drivers
parentch_ktls: packet handling prior to start marker (diff)
downloadlinux-659bf0383d15b07e492e27443d87736b24171558.tar.xz
linux-659bf0383d15b07e492e27443d87736b24171558.zip
ch_ktls: don't free skb before sending FIN
If its a last packet and fin is set. Make sure FIN is informed to HW before skb gets freed. Fixes: 429765a149f1 ("chcr: handle partial end part of a record") Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c12
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
index bbda71b7f98b..a8062e038ebc 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c
@@ -1932,6 +1932,9 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
flags);
goto out;
}
+
+ if (th->fin)
+ skb_get(skb);
}
if (unlikely(tls_record_is_start_marker(record))) {
@@ -2006,8 +2009,11 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
__skb_frag_unref(&record->frags[i]);
}
/* if any failure, come out from the loop. */
- if (ret)
+ if (ret) {
+ if (th->fin)
+ dev_kfree_skb_any(skb);
return NETDEV_TX_OK;
+ }
/* length should never be less than 0 */
WARN_ON(data_len < 0);
@@ -2020,8 +2026,10 @@ static int chcr_ktls_xmit(struct sk_buff *skb, struct net_device *dev)
/* tcp finish is set, send a separate tcp msg including all the options
* as well.
*/
- if (th->fin)
+ if (th->fin) {
chcr_ktls_write_tcp_options(tx_info, skb, q, tx_info->tx_chan);
+ dev_kfree_skb_any(skb);
+ }
return NETDEV_TX_OK;
out: