diff options
| author | Fuyun Liang <liangfuyun1@huawei.com> | 2017-11-03 05:18:26 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-11-03 13:36:49 +0100 |
| commit | 2b39cabb2a283cea0c3d96d9370575371726164f (patch) | |
| tree | b8124ee01bbd43dcf9f0341b9c5768e40065d684 /drivers | |
| parent | net: hns3: fix for getting autoneg in hns3_get_link_ksettings (diff) | |
| download | linux-2b39cabb2a283cea0c3d96d9370575371726164f.tar.xz linux-2b39cabb2a283cea0c3d96d9370575371726164f.zip | |
net: hns3: fix for getting advertised_caps in hns3_get_link_ksettings
This patch fixes a bug for ethtool's get_link_ksettings().
The advertising for autoneg is always added to advertised_caps
whether autoneg is enable or disable. This patch fixes it.
Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c index 367b20cef294..0e10a43e29b3 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c @@ -640,6 +640,9 @@ static int hns3_get_link_ksettings(struct net_device *netdev, break; } + if (!cmd->base.autoneg) + advertised_caps &= ~HNS3_LM_AUTONEG_BIT; + /* now, map driver link modes to ethtool link modes */ hns3_driv_to_eth_caps(supported_caps, cmd, false); hns3_driv_to_eth_caps(advertised_caps, cmd, true); |