diff options
| author | Sumera Priyadarsini <sylphrenadin@gmail.com> | 2020-08-18 20:52:41 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-18 22:12:12 +0200 |
| commit | 989e4da042ca4a56bbaca9223d1a93639ad11e17 (patch) | |
| tree | 81a74249028e78ae530cf9518d9dbdadc348cfa3 /drivers | |
| parent | Merge branch 'cxgb4-Fix-ethtool-selftest-flits-calculation' (diff) | |
| download | linux-989e4da042ca4a56bbaca9223d1a93639ad11e17.tar.xz linux-989e4da042ca4a56bbaca9223d1a93639ad11e17.zip | |
net: gianfar: Add of_node_put() before goto statement
Every iteration of for_each_available_child_of_node() decrements
reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.
Fix a potential memory leak in gianfar.c by inserting of_node_put()
before the goto statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/freescale/gianfar.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index b513b8c5c3b5..41dd3d0f3452 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -750,8 +750,10 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev) continue; err = gfar_parse_group(child, priv, model); - if (err) + if (err) { + of_node_put(child); goto err_grp_init; + } } } else { /* SQ_SG_MODE */ err = gfar_parse_group(np, priv, model); |