diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2017-09-26 20:17:52 +0200 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2017-09-28 18:13:06 +0200 |
| commit | b8ff981f88df03c72a4de2f6eaa9ce447a10ac03 (patch) | |
| tree | a579c2ee08e7a64aa872a19dae3507a74a9b4471 /drivers | |
| parent | dax: pr_err() strings should end with newlines (diff) | |
| download | linux-b8ff981f88df03c72a4de2f6eaa9ce447a10ac03.tar.xz linux-b8ff981f88df03c72a4de2f6eaa9ce447a10ac03.zip | |
libnvdimm, region : make 'resource' attribute only readable by root
For the same reason that /proc/iomem returns 0's for non-root readers
and acpi tables are root-only, make the 'resource' attribute for region
devices only readable by root. Otherwise we disclose physical address
information.
Fixes: 802f4be6feee ("libnvdimm: Add 'resource' sysfs attribute to regions")
Cc: <stable@vger.kernel.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/nvdimm/region_devs.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 829d760f651c..abaf38c61220 100644 --- a/drivers/nvdimm/region_devs.c +++ b/drivers/nvdimm/region_devs.c @@ -562,8 +562,12 @@ static umode_t region_visible(struct kobject *kobj, struct attribute *a, int n) if (!is_nd_pmem(dev) && a == &dev_attr_badblocks.attr) return 0; - if (!is_nd_pmem(dev) && a == &dev_attr_resource.attr) - return 0; + if (a == &dev_attr_resource.attr) { + if (is_nd_pmem(dev)) + return 0400; + else + return 0; + } if (a == &dev_attr_deep_flush.attr) { int has_flush = nvdimm_has_flush(nd_region); |