diff options
| author | Alexander Fomichev <fomichev.ru@gmail.com> | 2020-02-13 16:05:07 +0100 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2020-03-13 15:03:49 +0100 |
| commit | 788b041afd9a66ce3871734e87e908dc47739f39 (patch) | |
| tree | 5a03c3f62facdaf149a336fe8693e1091acfd17d /drivers | |
| parent | ntb_tool: Fix printk format (diff) | |
| download | linux-788b041afd9a66ce3871734e87e908dc47739f39.tar.xz linux-788b041afd9a66ce3871734e87e908dc47739f39.zip | |
ntb_hw_switchtec: Fix ntb_mw_clear_trans error if size == 0
ntb_mw_set_trans() should work as ntb_mw_clear_trans() when size == 0 and/or
addr == 0. But error in xlate_pos checking condition prevents this.
Fix the condition to make ntb_mw_clear_trans() working.
Fixes: 87d11e645e31 (NTB: switchtec_ntb: Add memory window support)
Signed-off-by: Alexander Fomichev <fomichev.ru@gmail.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c index 86ffa716eaf2..4c6eb61a6ac6 100644 --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c @@ -285,7 +285,7 @@ static int switchtec_ntb_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx, if (widx >= switchtec_ntb_mw_count(ntb, pidx)) return -EINVAL; - if (xlate_pos < 12) + if (size != 0 && xlate_pos < 12) return -EINVAL; if (!IS_ALIGNED(addr, BIT_ULL(xlate_pos))) { |