diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2021-09-27 15:15:47 +0200 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2021-09-27 16:09:42 +0200 |
| commit | 811b5440c6e4998755990fd2c1455f42f3aae3b0 (patch) | |
| tree | 63e6c8324857da74374f3a26a4a397a48fe52fa5 /drivers | |
| parent | Linux 5.15-rc1 (diff) | |
| download | linux-811b5440c6e4998755990fd2c1455f42f3aae3b0.tar.xz linux-811b5440c6e4998755990fd2c1455f42f3aae3b0.zip | |
led-class-flash: fix -Wrestrict warning
gcc-11 warns when building with W=1:
drivers/leds/led-class-flash.c: In function 'flash_fault_show':
drivers/leds/led-class-flash.c:210:16: error: 'sprintf' argument 3 overlaps destination object 'buf' [-Werror=restrict]
210 | return sprintf(buf, "%s\n", buf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/leds/led-class-flash.c:187:54: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
187 | struct device_attribute *attr, char *buf)
| ~~~~~~^~~
There is no need for the sprintf() here when a strcat() does
the same thing without invoking undefined behavior.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/leds/led-class-flash.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c index 185e17055317..6fe9d700dfef 100644 --- a/drivers/leds/led-class-flash.c +++ b/drivers/leds/led-class-flash.c @@ -207,7 +207,7 @@ static ssize_t flash_fault_show(struct device *dev, mask <<= 1; } - return sprintf(buf, "%s\n", buf); + return strlen(strcat(buf, "\n")); } static DEVICE_ATTR_RO(flash_fault); |