summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDavid Lechner <david@lechnology.com>2018-09-13 02:48:30 +0200
committerSebastian Reichel <sre@kernel.org>2018-09-16 11:29:18 +0200
commit87a2b65fc855e6be50f791c2ebbb492541896827 (patch)
treed084c9d9e8d7e4fe036ff128e2bb7d369f66355a /drivers
parentpower: supply: bq25890_charger: Read back the current battery voltage (diff)
downloadlinux-87a2b65fc855e6be50f791c2ebbb492541896827.tar.xz
linux-87a2b65fc855e6be50f791c2ebbb492541896827.zip
power: supply: sysfs: ratelimit property read error message
This adds rate limiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuously reading a property that returns an error. Signed-off-by: David Lechner <david@lechnology.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/power/supply/power_supply_sysfs.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index 6170ed8b6854..dce24f596160 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
dev_dbg(dev, "driver has no data for `%s' property\n",
attr->attr.name);
else if (ret != -ENODEV && ret != -EAGAIN)
- dev_err(dev, "driver failed to report `%s' property: %zd\n",
+ dev_err_ratelimited(dev,
+ "driver failed to report `%s' property: %zd\n",
attr->attr.name, ret);
return ret;
}