diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-07-17 09:21:28 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-07-19 00:07:15 +0200 |
| commit | 0a6efc78c0c22d60040da0dc98a0844e7c0d0647 (patch) | |
| tree | 35239bcfbd1183deec54e7c9c43d2ec92da03e2e /drivers | |
| parent | net: dccp: fix sign bug (diff) | |
| download | linux-0a6efc78c0c22d60040da0dc98a0844e7c0d0647.tar.xz linux-0a6efc78c0c22d60040da0dc98a0844e7c0d0647.zip | |
arcnet: fix signed bug in probe function
probe_irq_off() returns the first irq found or if two irqs are found
then it returns the negative of the first irq found. We can cast
dev->irq to an int so that the test for negative values works.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/arcnet/com20020-isa.c | 4 | ||||
| -rw-r--r-- | drivers/net/arcnet/com90io.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/arcnet/com20020-isa.c b/drivers/net/arcnet/com20020-isa.c index 0402da30a4ed..37272827ee55 100644 --- a/drivers/net/arcnet/com20020-isa.c +++ b/drivers/net/arcnet/com20020-isa.c @@ -90,14 +90,14 @@ static int __init com20020isa_probe(struct net_device *dev) outb(0, _INTMASK); dev->irq = probe_irq_off(airqmask); - if (dev->irq <= 0) { + if ((int)dev->irq <= 0) { BUGMSG(D_INIT_REASONS, "Autoprobe IRQ failed first time\n"); airqmask = probe_irq_on(); outb(NORXflag, _INTMASK); udelay(5); outb(0, _INTMASK); dev->irq = probe_irq_off(airqmask); - if (dev->irq <= 0) { + if ((int)dev->irq <= 0) { BUGMSG(D_NORMAL, "Autoprobe IRQ failed.\n"); err = -ENODEV; goto out; diff --git a/drivers/net/arcnet/com90io.c b/drivers/net/arcnet/com90io.c index 4cb401813b7e..eb27976dab37 100644 --- a/drivers/net/arcnet/com90io.c +++ b/drivers/net/arcnet/com90io.c @@ -213,7 +213,7 @@ static int __init com90io_probe(struct net_device *dev) outb(0, _INTMASK); dev->irq = probe_irq_off(airqmask); - if (dev->irq <= 0) { + if ((int)dev->irq <= 0) { BUGMSG(D_INIT_REASONS, "Autoprobe IRQ failed\n"); goto err_out; } |