diff options
| author | Ralf Baechle <ralf@linux-mips.org> | 2006-12-13 09:34:57 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-13 18:05:52 +0100 |
| commit | 34f8f0a5e953d3e40c4419e5e5c4b6fd14f7ebf2 (patch) | |
| tree | 6a4630fc8ca0ee9d49e7411e992a4b16ee2ca282 /drivers | |
| parent | [PATCH] Fix numerous kcalloc() calls, convert to kzalloc() (diff) | |
| download | linux-34f8f0a5e953d3e40c4419e5e5c4b6fd14f7ebf2.tar.xz linux-34f8f0a5e953d3e40c4419e5e5c4b6fd14f7ebf2.zip | |
[PATCH] tty: remove useless memory barrier
I don't see why there is a memory barrier in copy_from_read_buf() at all.
Even if it was useful spin_unlock_irqrestore implies a barrier.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/char/n_tty.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c index e96a00fe1389..2bdb0144a22e 100644 --- a/drivers/char/n_tty.c +++ b/drivers/char/n_tty.c @@ -1151,7 +1151,6 @@ static int copy_from_read_buf(struct tty_struct *tty, n = min(*nr, n); spin_unlock_irqrestore(&tty->read_lock, flags); if (n) { - mb(); retval = copy_to_user(*b, &tty->read_buf[tty->read_tail], n); n -= retval; spin_lock_irqsave(&tty->read_lock, flags); |