diff options
| author | Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-12-06 21:20:15 +0100 |
|---|---|---|
| committer | MyungJoo Ham <myungjoo.ham@samsung.com> | 2018-01-02 01:36:54 +0100 |
| commit | 63f1e05f7fe9ca509c60154d6a833abf96eecdc9 (patch) | |
| tree | c7166465e745e3d073bf07b578bff73cd28394a8 /drivers | |
| parent | PM / devfreq: Propagate error from devfreq_add_device() (diff) | |
| download | linux-63f1e05f7fe9ca509c60154d6a833abf96eecdc9.tar.xz linux-63f1e05f7fe9ca509c60154d6a833abf96eecdc9.zip | |
PM / devfreq: Fix potential NULL pointer dereference in governor_store
df->governor is being dereferenced before it is null checked,
hence there is a potential null pointer dereference.
Notice that df->governor is being null checked at line 1004:
if (df->governor) {, which implies it might be null.
Fix this by null checking df->governor before dereferencing it.
Addresses-Coverity-ID: 1401988 ("Dereference before null check")
Fixes: bcf23c79c4e4 ("PM / devfreq: Fix available_governor sysfs")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/devfreq/devfreq.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 99c4021fc33b..fe2af6aa88fc 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -996,7 +996,8 @@ static ssize_t governor_store(struct device *dev, struct device_attribute *attr, if (df->governor == governor) { ret = 0; goto out; - } else if (df->governor->immutable || governor->immutable) { + } else if ((df->governor && df->governor->immutable) || + governor->immutable) { ret = -EINVAL; goto out; } |